[FFmpeg-devel] [PATCH]Add RoQ regression tests

[Vitor Sessak]

Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch adds RoQ regression tests.
> Only tested on x86-32.
> 
> Please comment, Carl Eugen

[...]

> 
> Index: tests/rotozoom.regression.ref
> ===================================================================
> --- tests/rotozoom.regression.ref	(Revision 15625)
> +++ tests/rotozoom.regression.ref	(Arbeitskopie)
> @@ -285,3 +285,7 @@
>  10371830 ./tests/data/a-pcm_s24daud.302
>  fff1dc03aa2750031203a7d72b832fad *./tests/data/pcm.rotozoom.out.wav
>  stddev: 9416.45 PSNR: 16.84 bytes:  6911840/  1058444
> +1790d6feaa7fb5ad8f4e1c0bd52a10bb *./tests/data/a-roqvideo.roq
> +942005 ./tests/data/a-roqvideo.roq
> +f8a0bd9c5ebe43efefe1c2faf1077257 *./tests/data/roqvideo.rotozoom.out.yuv
> +stddev:   52.02 PSNR: 13.80 bytes: 17943552/  7603200
> Index: tests/libav.regression.ref
> ===================================================================
> --- tests/libav.regression.ref	(Revision 15615)
> +++ tests/libav.regression.ref	(Arbeitskopie)
> @@ -132,3 +132,6 @@
>  304128 ./tests/data/b-libav-yuv440p.yuv
>  10c8507ad38d0ce5e8cd0f1dd49b0d26 *./tests/data/b-libav-yuvj440p.yuv
>  304128 ./tests/data/b-libav-yuvj440p.yuv
> +84bdcbed211f76206cabc9a712107ffe *./tests/data/b-libav.roq
> +541110 ./tests/data/b-libav.roq
> +./tests/data/b-libav.roq CRC=0xc3a8fee8
> Index: tests/regression.sh
> ===================================================================
> --- tests/regression.sh	(Revision 15625)
> +++ tests/regression.sh	(Arbeitskopie)
> @@ -373,6 +373,11 @@
>  do_video_decoding "" "-pix_fmt yuv420p -sws_flags area+accurate_rnd+bitexact"
>  fi
>  
> +if [ -n "$do_roqvideo" ] ; then
> +do_video_encoding roqvideo.roq
> +do_video_decoding

I think here should be

do_video_decoding "" "-pix_fmt yuv420p"

or else you'll end up comparing yuv444p to yuv420p.

-Vitor