[FFmpeg-devel] [PATCH] RealAudio SIPR @16k decoder (4/4) demuxer

[Michael Niedermayer]

On Wed, Sep 24, 2008 at 10:19:08PM +0200, Benjamin Larsson wrote:
> Michael Niedermayer wrote:
> > 
> >> ------------------------------------
> >> s=10
> >> wav_write_header
> >> av_log(s, AV_LOG_ERROR, "%s codec not supported in WAVE format\n",
> >>  s->streams[0]->codec->codec->name); with s->streams[0]->codec->codec
> >> being NULL
> >>
> >> I removed the lookup and it ran better.
> > 
> > fixed
> 
> Thanks.
> 

> > 
> > 
> >> ------------------------------------
> >> At s=85 it crashed on a division by zero, block_align was 0 cause of
> >> sub_packet_size corruption. Added a check for nozero block_size at the
> >> end of rm_read_audio_stream_info fixed it.
> > 
> > a clean fix is welcome, checking block_align==0 for all codecs is likely
> > going to break some ...
> > 
> 
> Ok, I'll look closer tomorrow exactly what codecs that need that check.

has this been done?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081016/15ea34f5/attachment.pgp>