[FFmpeg-devel] [PATCH] RealAudio SIPR @16k decoder (4/4) demuxer

[Benjamin Larsson]

Michael Niedermayer wrote:
> On Wed, Sep 24, 2008 at 10:33:53AM +0200, Benjamin Larsson wrote:
>   
>> Michael Niedermayer wrote:
>>     
>>> On Sat, Jul 12, 2008 at 02:17:03PM +0700, Vladimir Voroshilov wrote:
>>>       
> [...]
>   
>>>       
>>>> +                          // Perform reordering
>>>> +                          for(n=0; n < 38; n++) {
>>>> +                              int j;
>>>> +                              int i = bs * sipr_swaps[n][0];
>>>> +                              int o = bs * sipr_swaps[n][1];
>>>> +                                // swap nibbles of block 'i' with 'o'
>>>> +                                for(j = 0;j < bs; j++) {
>>>>         
>>> Fix the indention, and check if the code cannot write out of the
>>> array. Ill checkit as well but the rm demuxer is messy its better if
>>> its checked by more than 1 person.
>>>       
>> Indentation fixed. To me by inspection the code looks ok, and this code
>> has been running in mplayer for as long as it had binary rm codec
>> support. And I ran it through valgrind with no complaints on a test file.
>>     
>
> Could you try the code with some damaged files? (created by tools/trasher or
> some other tool)
>
> ill review the new patch soon.
>
>   

Ping ?

MvH
Benjamin Larsson