[FFmpeg-devel] [PATCH] QCELP decoder

[Kenan Gillet]

On Sun, Oct 12, 2008 at 8:43 AM, Diego Biurrun <diego at biurrun.de> wrote:
> On Fri, Oct 10, 2008 at 10:03:11AM -0700, Kenan Gillet wrote:
>>
>> The patch using the reference code is at [2]. As a plan of action, I
>> propose to work on the inclusion of this patch as a first step, and
>> then continue on working the SoC decoder
>>
>> what do you think ?
>>
>> [2] http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2006-December/020223.html
>
> This is not the way to go.  If you want to add glue code for using the
> reference qcelp decoder, you should convert the reference decoder into a
> proper library that can be linked with libavcodec.  The same thing was
> done for AMR.  An ugly build system where the reference code has to be
> added to libavcodec is not acceptable.

ok, I have a very simple makefile that converts the reference code
into a library,
given that you can compile the reference code, and some updated glue code.
I'll work it into shape and post if somebody is interested but I had
to hack a little
bit the reference code to make it compile under the infamous MacOS linker :(

I prefer to focus on the SoC decoder since the reference code is a float
 implementation and thus as Michael Niedermayer wrote:
"ok, if theres no fixed point reference, then theres also no point in
writing one for regression/compliance tests."

Kenan