[FFmpeg-devel] Pretty printing patch
Diego Biurrun
diego
Tue Oct 14 12:04:36 CEST 2008
On Sat, Oct 11, 2008 at 03:42:40PM -0700, Roman V. Shaposhnik wrote:
> On Wed, 2008-10-08 at 20:04 +0200, Michael Niedermayer wrote:
> > > - run= new_dv_vlc_run[code] + 1;
> > > - level= new_dv_vlc_level[code];
> > > + run = new_dv_vlc_run[code] + 1;
> > > + level = new_dv_vlc_level[code];
> >
> > i think
> > run = new_dv_vlc_run [code] + 1;
> > level = new_dv_vlc_level[code];
> >
> > would be even better
>
> Good point.
If you like it that way, fine with me.
> > > - s->dv_zigzag[1][i] = dsp.idct_permutation[(j&7) + (j&8)*4 + (j&48)/2];
> > > + s->dv_zigzag[1][i] = dsp.idct_permutation[(j & 7) + (j & 8) * 4 + (j & 48) / 2];
> >
> > IMHO the previous was more readable, but of course its your code and
> > your decission on how you want it to look.
>
> To tell you the truth -- as far as these changes go I'm on the fence
> myself. But it sure helps to know your opinion.
>
> Diego, what's your take? It is your patch after all -- I was merely
> reapplying it on top of my changes and submitting it for review ;-)
I definitely prefer spaces around operators. I find it unnecessarily
hard to tell apart numbers and variable names and operators at a glance
in cramped conglomerations of characters.
Diego
More information about the ffmpeg-devel
mailing list