[FFmpeg-devel] Problem with cross compilation / need guidance for patch submission

[Dominik 'Rathann' Mierzejewski]

On Monday, 13 October 2008 at 10:59, Panagiotis Issaris wrote:
> 
> On Mon, 2008-10-13 at 10:33 +0200, Panagiotis Issaris wrote:
> > On Sun, 2008-10-12 at 17:33 +0000, Edouard Gomez wrote:
> > > Diego Biurrun <diego <at> biurrun.de> writes:
> > > > The problem really is in FAAC and should be fixed there.  Submit a patch
> > > > to them that changes the preprocessor condition to use __WIN32__ or one
> > > > of the other variants.
> > > 
> > > I understand your point.
> > > 
> > > What you're telling here is that ffmpeg is relying on other libs to be
> > > iso c99. This is a very unrealistic approach as most of the libs are
> > > not iso c99 compliant. 
> > > 
> > > To put it simply, the ffmpeg build system is at fault because it imposes
> > > the std=c99 to headers that were never thought to be compiled like that.
> > > Why fix external headers ? Isn't the responsability of the includer to
> > > use the headers correctly ?
> > 
> > Actually, I do not think that ffmpeg is at fault, and I do not think it
> > has anything to do with C99 either. In fact, Microsofts C/C++ compiler
> > does not define WIN32 at all, it defines _WIN32. A lot of software
> > checks for WIN32 and this works only because the Visual Studio IDE by
> > default adds -DWIN32 to the compiler flags.
> 
> I've sent a patch to FAAC, but the mailing list seems to contain only
> spam...

I think it's better to send patches directly to current developers.
I did so with faad2 and they were committed.

Regards,
R.

-- 
MPlayer http://mplayerhq.hu | Livna http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan