[FFmpeg-devel] [PATCH]Enable ac3 decoding test
Justin Ruggles
justin.ruggles
Mon Oct 13 02:34:01 CEST 2008
Michael Niedermayer wrote:
> On Mon, Oct 13, 2008 at 02:01:33AM +0200, Carl Eugen Hoyos wrote:
>> Hi!
>>
>> Attached patch enables ac3 decoding test. Only tested on x86-32 (icc and
>> gcc).
>>
>> Carl Eugen
>
>> Index: tests/rotozoom.regression.ref
>> ===================================================================
>> --- tests/rotozoom.regression.ref (Revision 15601)
>> +++ tests/rotozoom.regression.ref (Arbeitskopie)
>> @@ -177,6 +177,8 @@
>> stddev: 4394.71 PSNR: 23.46 bytes: 1053352/ 1058444
>> aefe11ab5067621a1c674859d6413891 *./tests/data/a-ac3.rm
>> 98203 ./tests/data/a-ac3.rm
>> +39d5646cba5a6cfedfd58845e6df3c06 *./tests/data/ac3.rotozoom.out.wav
>> +stddev:10496.20 PSNR: 15.90 bytes: 1056812/ 1058444
>
> this does not look like it is working, stddev should be smaller.
> are you sure that everything like the "shift" parameter to tiny_psnr
> is correct?
>
> besides this, this needs to be tested on x86-64 to ensure the test does
> work on more than just x86-32. (i can do this if you have no x86-64 once
> the stuff looks like its working ...).
I don't know if shift is in bytes or samples... but it should be +/- 256
samples or 1024 bytes depending on what order it is compared it.
-Justin
More information about the ffmpeg-devel
mailing list