[FFmpeg-devel] Problem with cross compilation / need guidance for patch submission

[Edouard Gomez]

Edouard Gomez <ed.gomez <at> free.fr> writes:
>  - add -DWIN32 when compiling for the win32 platform. Requires adding a CFLAG 
>    during configure.

This one breaks libmp3lame compilation because of a similar problem.

I think the best solution is to fix defines correctly before including
other libs headers for faac and mp3lame. Here are two possible fixes.

For faac it would be:
/* In case -std=c99 option is used, we must defined those 
 * so the external lib header doesn't break
#if defined(_WIN32) && !defined(WIN32)
#define WIN32 1
#endif
#include <faac.h>

For lame mp3:
/* In case -std=c99 option is used, we must defined those 
 * so the external lib header doesn't break
#if defined(_WIN32) && !defined(WIN32)
#define WIN32 1
#define _cdecl __cdecl
#endif
#include <lame/lame.h>

If you're fine with this, i'll submit a patch.

-- 
Edouard Gomez