[FFmpeg-devel] [PATCH 4/4] Include headers for optional libraries only when enabled.

[Diego Biurrun]

On Thu, Oct 02, 2008 at 09:26:03PM +0200, Aurelien Jacobs wrote:
> Diego Biurrun wrote:
> 
> > On Thu, Oct 02, 2008 at 06:55:19PM +0200, Diego 'Flameeyes' Petten? wrote:
> > > Include the headers for libavfilter, libswscale and libpostproc when
> > > they are enabled (and thus linked in).
> > > 
> > > --- a/cmdutils.c
> > > +++ b/cmdutils.c
> > > @@ -26,10 +26,16 @@
> > >  
> > > +#if ENABLE_AVFILTER
> > 
> > You should use CONFIG_ definitions in preprocessor checks.
> 
> Why ?

Consistency.  We do have two different definitions, it was my impression
that they should be used for different purposes.

Diego