[FFmpeg-devel] [PATCH] Make global_quality a float

Michael Niedermayer michaelni
Sat Oct 11 18:19:38 CEST 2008

On Sat, Oct 11, 2008 at 12:40:34PM +0200, Nicolas George wrote:
> Hi.
> The gloal_quality field in AVCodecContext is currently an integer, but IMHO
> it should be a float: a lot of codecs treat it as a float, it is scaled by a
> 118 factor which leads to odd rounding errors, it is sometimes stored to or
> from other float fields, etc.

floats lead to unpredictable rounding, changing it to a float would make
regression tests a step more brittle and less portable between different
platforms that have different FPUs and compilers.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081011/e40b4eb2/attachment.pgp>

More information about the ffmpeg-devel mailing list