[FFmpeg-devel] [PATCH] Add preset options documentation strings

[Michael Niedermayer]

On Thu, Oct 09, 2008 at 09:26:59PM +0200, Stefano Sabatini wrote:
> On date Sunday 2008-10-05 17:32:42 +0200, Stefano Sabatini encoded:
> > Hi,
> > as in subject.
> > 
> > Regards.
> > -- 
> > FFmpeg = Forgiving and Foolish Multimedia Problematic Elegant Governor
> 
> > Index: ffmpeg.c
> > ===================================================================
> > --- ffmpeg.c	(revision 15563)
> > +++ ffmpeg.c	(working copy)
> > @@ -3832,9 +3832,9 @@
> >      { "vbsf", OPT_FUNC2 | HAS_ARG | OPT_VIDEO | OPT_EXPERT, {(void*)opt_bsf}, "", "bitstream_filter" },
> >      { "sbsf", OPT_FUNC2 | HAS_ARG | OPT_SUBTITLE | OPT_EXPERT, {(void*)opt_bsf}, "", "bitstream_filter" },
> >  
> > -    { "apre", OPT_FUNC2 | HAS_ARG | OPT_AUDIO | OPT_EXPERT, {(void*)opt_preset}, "", "preset" },
> > -    { "vpre", OPT_FUNC2 | HAS_ARG | OPT_VIDEO | OPT_EXPERT, {(void*)opt_preset}, "", "preset" },
> > -    { "spre", OPT_FUNC2 | HAS_ARG | OPT_SUBTITLE | OPT_EXPERT, {(void*)opt_preset}, "", "preset" },
> > +    { "apre", OPT_FUNC2 | HAS_ARG | OPT_AUDIO | OPT_EXPERT, {(void*)opt_preset}, "set the preset file for the audio codec", "preset" },
> > +    { "vpre", OPT_FUNC2 | HAS_ARG | OPT_VIDEO | OPT_EXPERT, {(void*)opt_preset}, "set the preset file for the video codec", "preset" },
> > +    { "spre", OPT_FUNC2 | HAS_ARG | OPT_SUBTITLE | OPT_EXPERT, {(void*)opt_preset}, "set the preset file for the subtitle codec", "preset" },
> >  
> >      { "default", OPT_FUNC2 | HAS_ARG | OPT_AUDIO | OPT_VIDEO | OPT_EXPERT, {(void*)opt_default}, "generic catch all option", "" },
> >      { NULL, },
> 
> I'll apply this on the weekend if no one objects.

i object

and i always hate it when i have to rewrite your documentation "improvments"
from scratch.
anyway
try
"set the video/audio/subtitle options to the indicated presets"


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081010/c953e72e/attachment.pgp>