[FFmpeg-devel] [PATCH] Simplify checks for particular GCC versions.

[Måns Rullgård]

Diego Biurrun wrote:
> On Thu, Oct 09, 2008 at 03:43:31PM +0200, Diego 'Flameeyes' Petten? wrote:
>>
>> --- a/libavutil/common.h
>> +++ b/libavutil/common.h
>> @@ -41,8 +41,26 @@
>>
>> +/* Check ICC first since it'll appear as GCC otherwise */
>> +#if __ICC

#ifdef

>> +# if __ICC >= 1010
>> +   /* We know ICC 10.1 behaves like GCC 4.1 for us */
>> +#  define FF_GCC_COMBVERSION ((4 << 24) + (1 << 16) + 0)
>> +# else
>> +#  define FF_GCC_COMBVERSION ((4 << 24) + (0 << 16) + 0)
>> +# endif
>> +#elif defined(__GNUC__)
>> +# define FF_GCC_COMBVERSION                                             \
>> +  ((__GNUC__ << 24) + (__GNUC_MINOR__ << 16) + __GNUC_PATCHLEVEL__)
>> +#else
>> +# define FF_GCC_COMBVERSION 0
>> +#endif
>
> This could be split into a separate patch.  Apart from that the patch
> looks OK to me.

I only looked at it briefly, but it seems OK.

-- 
M?ns Rullg?rd
mans at mansr.com