[FFmpeg-devel] [PATCH] timestamp discontinuity in subtitles is OK

[Aurelien Jacobs]

Michael Niedermayer wrote:

> On Mon, Oct 06, 2008 at 08:24:45AM -0000, Wolfram Gloger wrote:
> > Hi,
> > 
> > > i think there is a easier solution
> > > just check for AVFMT_TS_DISCONT which would prevent misdetection in all
> > > containers that do not allow discontinuities.
> > 
> > But we _do_ have containers with AVFMT_TS_DISCONT which can have
> > subtitles in them (dvbsub in mpegts, dvdsub in mpeg), so this wouldn't
> > help.
> 
> when discontinuities are allowed, then they likely are also allowed
> between subtitle packets (but if you disagree, feel free to quote the specs,
> id be happy to hear what they say ...),
> thus whichever way is used to detect them, the detection should
> be needed between subtitle packets as well.
> 
> a check for AVFMT_TS_DISCONT is correct, one for subtitles is not AFAICS.
> The real question is what do the dvbsub/dvdsub specs say about
> discontinuities?

I guess attached patch is what you meant.

Aurel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ts_discont.diff
Type: text/x-patch
Size: 1255 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081009/40760da6/attachment.bin>