[FFmpeg-devel] [PATCH] Set systems that should support DOS paths in configure

Ramiro Polla ramiro.polla
Tue Oct 7 18:45:56 CEST 2008

On Tue, Oct 7, 2008 at 1:29 PM, M?ns Rullg?rd <mans at mansr.com> wrote:
> Fran?ois Revol wrote:
>>> On Mon, Oct 06, 2008 at 01:42:06PM -0300, Ramiro Polla wrote:
>>> > According to [0], only letters are allowed for the drive letter
>>> > (altough I've seen some program, fsdext2 IIRC, using numbers).
>>> > Added
>>> > isalpha() for path[0].
>>> Am I the only one who feels that isalpha is simply inappropriate?
>>> Driver letters in DOS to my knowledge are always A-Z (case
>>> insensitive),
>>> and certainly do not depend on locale.
>>> For example the man page says:
>>> "In some locales, there may be additional characters for which
>>> isalpha() is true?letters
>>> which are neither upper case nor lower case."
>>> I think this is not at all what we want (though we may already assume
>>> C locale in other places)...

According to MSDN [0], isalpha() on Windows doesn't take locale into
account. But we shouldn't assume this behavior for OS/2 nor cygwin, so
you're right.

>> probably... and DOS likely uses a 26 bit bitmap in some places anyway.
>> Same on TOS (Atari) ;)
>> You'll probably want >= 'a' && <= 'z' || >= 'A' && <= 'Z'

New patch attached. It has lots of parentheses to silence gcc
warnings. Are they all necessary?

> How does MSDOS^W Windows handle the whole drive letter thing in funny
> locales?

Lots of places on MSDN specify only A-Z case insensitive. But it would
be funny to mount the ?:\ drive...

Is there anyone with such a locale that can confirm whether it's possible?

Ramiro Polla
[0] http://msdn.microsoft.com/en-us/library/xt82b8z8.aspx
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dospaths_9.diff
Type: text/x-diff
Size: 2667 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081007/0cf30956/attachment.diff>

More information about the ffmpeg-devel mailing list