[FFmpeg-devel] [PATCH] Set systems that should support DOS paths in configure

François Revol revol
Tue Oct 7 18:07:19 CEST 2008


> On Mon, Oct 06, 2008 at 01:42:06PM -0300, Ramiro Polla wrote:
> > According to [0], only letters are allowed for the drive letter
> > (altough I've seen some program, fsdext2 IIRC, using numbers). 
> > Added
> > isalpha() for path[0].
> 
> Am I the only one who feels that isalpha is simply inappropriate?
> Driver letters in DOS to my knowledge are always A-Z (case 
> insensitive),
> and certainly do not depend on locale.
> For example the man page says:
> "In some locales, there may be additional characters for which 
> isalpha() is true?letters
> which are neither upper case nor lower case."
> I think this is not at all what we want (though we may already assume 
> C
> locale in other places)...

probably... and DOS likely uses a 26 bit bitmap in some places anyway.
Same on TOS (Atari) ;)

You'll probably want >= 'a' && <= 'z' || >= 'A' && <= 'Z'

Unless you want to account for AmigaDOS devices which can actually have 
longer names.

Fran?ois.




More information about the ffmpeg-devel mailing list