[FFmpeg-devel] [PATCH] Set systems that should support DOS paths in configure

Ramiro Polla ramiro.polla
Tue Oct 7 17:43:58 CEST 2008


Hi,

>>>> Index: libavformat/os_support.h
>>>> ===================================================================
>>>> --- libavformat/os_support.h  (revision 15572)
>>>> +++ libavformat/os_support.h  (working copy)
>>>> @@ -32,6 +32,15 @@
>>>>  #  define lseek(f,p,w) _lseeki64((f), (p), (w))
>>>>  #endif
>>>>
>>>> +static inline int is_dos_path(const char *path)
>>>> +{
>>>> +#ifdef HAVE_DOS_PATHS
>>>> +    if (isalpha(path[0]) && path[1] == ':')
>>>> +        return 1;
>>>> +#endif
>>>> +    return 0;
>>>> +}
>>>> +
>>>>  #ifdef __BEOS__
>>>>  #  include <sys/socket.h>
>>>>  #  include <netinet/in.h>
>>>
>>> isalpha() needs #include <ctype.h>.  I don't see it anywhere in the file.
>>
>> Added under a #ifdef HAVE_DOS_PATHS.
>
> Standard headers don't need #ifdef in most cases.

I thought one of the reasons to #ifdef'ing it was to avoid including
an unnecessary header.

But if it's ok to unconditionally include it, I'll commit this on
Thursday without the #ifdef, including it unconditionally.

Ramiro Polla




More information about the ffmpeg-devel mailing list