[FFmpeg-devel] [PATCH] Simplify checks for particular GCC versions.
Diego 'Flameeyes' Pettenò
Mon Oct 6 16:14:58 CEST 2008
M?ns Rullg?rd <mans at mansr.com> writes:
> The order of tests here looks very strange, as does the line wrapping.
Hm the order of the test looked nice to me, the alternative would have
#if defined(__GNUC__) && !defined(__ICC)
but then it would, to me, look a bit strange logic wise:
"If the compiler is GCC and is not ICC..."
while the other makes a little more sense:
"If the compiler is ICC or is not GCC"
as we're explicitly blacklisting ICC here.
> Moreover, I suspect there is some version of gcc that icc is fully
> compatible with, at least in ways relevant to us. Defining this could
> obviate the need for explicit __ICC tests in some other places,
> rendering the code simpler and easier to maintain.
Sincerely I'd prefer if Intel starte asdvertising itself with the lowest
GCC version that they are actually compatible with, rather than telling
4.3.0 and then only half-assedly support it.
For what I can test here icc 10.1 supports all but three attributes used
in FFmpeg: force_align_arg_pointer, cold and alloc_size. The last two
are from GCC 4.3, the first is from 4.2; we could accept it as GCC 4.1.
Sun Studio Express instead does not support, in addition to the ones ICC
also doesn't support: used, deprecated and __printf__ as format
Diego "Flameeyes" Petten?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 196 bytes
Desc: not available
More information about the ffmpeg-devel