[FFmpeg-devel] [PATCH 0/6] Fix up some headers for checkheaders run

Diego Biurrun diego
Sat Oct 4 13:22:35 CEST 2008


On Sat, Oct 04, 2008 at 12:35:31PM +0200, Diego 'Flameeyes' Petten? wrote:
> Since Diego#1 suggested me to run my patch for compiler warnings
> through checkheaders, and checkheaders failed here right away at the
> start with cmdutils.h, I've decided to fix up some headers so that
> checkheders run would arrive at least to test the headers I touched.

I committed something based on your patch.

> There is one thing to note here: the template files that have .h as
> extension are making checkheaders fail. I'd propose to rename those to
> .c files. Although they are #include'd, they are certainly not
> headers, and should not checked for like headers (nor could be
> precompiled, I guess).

This sounds reasonable.  Maybe they should get a _template_ or similar
in their name as well.

Diego




More information about the ffmpeg-devel mailing list