[FFmpeg-devel] [PATCH] QCELP decoder

[Kenan Gillet]

On Fri, Oct 3, 2008 at 2:06 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
> On Fri, Oct 3, 2008 at 6:52 PM, Kenan Gillet <kenan.gillet at gmail.com> wrote:>
>>> For blue_earth.mov,tiny_psnr gives:
>>> stddev:  119.57 PSNR:  6.57 bytes: 19681324/ 19681324
>>> For h263.mov, tiny_psnr gives:
>>> stddev:   73.51 PSNR: 10.79 bytes: 13511404/ 13511404
>>> is it still ok, or is something wrong?
>> of course, something was wrong.
>> After corrected a bug,
>> the new values for this 2 files are:
>> blue_earth.mov: stddev:    2.51 PSNR: 40.11 bytes: 19681324/ 19681324
>> h263.mov        : stddev:    1.81 PSNR: 42.95 bytes: 13511404/ 13511404
>
> It is a pretty small difference, but I find it surprising that only
> these two files changed. If you decode it twice with the same ffmpeg
> binary, do you get the same output? If not, you could be reading some
> uninitialized memory.
>
>> is it now acceptable?
>
> For me (and probably for the others), yes.
>
actually it is is getting even smaller when i compare to a int output
version with the bug correction.
It now gives:
blue_earth.mov
stddev:    0.05 PSNR: 72.91 bytes: 19681324/ 19681324

h263.mov
stddev:    0.00 PSNR:100.29 bytes: 13511404/ 13511404


> PS: it is always nice to see people finishing old soc projects, nice work!
thanks :)

I will post an updated version later today.

Kenan