[FFmpeg-devel] [PATCH] Simplify checks for particular GCC versions.

[Diego Biurrun]

On Fri, Oct 03, 2008 at 08:42:38PM +0200, Diego 'Flameeyes' Petten? wrote:
> Instead of expanding the same check for GCC every time, create a macro
> FF_GCC_ATLEAST that can be used to check for a particular GCC version.
> 
> The FF_GCC_ATLEAST test ignores whatever ICC provides, since it does
> not support the full feature set of the GCC it fakes to provide.

In file included from libavcodec/aactab.c:30:
./libavutil/mem.h:45:19: error: missing binary operator before token "("
./libavutil/mem.h:51:19: error: missing binary operator before token "("
make: *** [libavcodec/aactab.o] Error 1

> --- a/libavutil/mem.h
> +++ b/libavutil/mem.h
> @@ -42,13 +42,13 @@
>  
> -#if defined(__GNUC__) && (__GNUC__ > 3 || __GNUC__ == 3 && __GNUC_MINOR__ > 0)
> +#if FF_GCC_ATLEAST(3,1,0) || __ICC

This macro is used within this header file without being declared.  This
is wrong, it works in other places by sheer luck.  Please run your code
through 'make checkheaders'.

Diego