[FFmpeg-devel] [PATCH] Support building dependency files with non-GCC compilers

[Måns Rullgård]

flameeyes at gmail.com (Diego 'Flameeyes' Petten?) writes:

> M?ns Rullg?rd <mans at mansr.com> writes:
>
>> Why did you move this block?
>
> Because the point where DEPEND_CMD was set before was before $cc was
> set.

Fair enough.

>> Do the Intel and Sun compilers produce correct output?
>
> I do think so, it seems to work fine; there is one quirk with Sun Studio
> compiler (it will ignore files in /usr/include but will keep on
> explicitly depending on its includes in /opt; I'll report it as a bug to
> them), but it's not like GCC/ICC are much better (they still report any
> file in /usr/include if the path was included with -I rather than
> -isystem, and almost nothing uses -isystem).

Why would you pass -I/usr/include?  Seems pretty daft to me.

>> Setting the command to "false" is a bit harsh, since it makes building
>> with any other compiler impossible.
>
> This is probably true, I guess I'm a bit harsh myself ;) Should I change
> it to true so that dependency information is just ignored when the
> compiler is not known?

Just leave this issue for now.

>> I'm still in favour of always using gcc.  It has quirks aplenty, but
>> there will be no new surprises.
>
> I've thought quickly about this but there is at least one problem:
> CFLAGS. The flags that will be used for Sun Studio or ICC might not work
> with GCC, and I wouldn't be surprised if GCC would then fail to properly
> generate the dependencies. I suppose it's a bet on what is most likely,
> I guess.

For dependencies, only -I and -D flags are needed.  We can easily
split these out.

-- 
M?ns Rullg?rd
mans at mansr.com