[FFmpeg-devel] [PATCH 8/8] Reduce ICC warnings regarding "enumerated type mixed with another type".

Måns Rullgård mans
Thu Oct 2 16:58:56 CEST 2008


Diego 'Flameeyes' Petten? wrote:
> The Intel C Compiler warns when using integers and enumerated types as
> the same type; try to reduce these warnings by declaring variables,
> attributes and return values used just to store CodecID values as
> "enum CodecID" type.

I agree this is the right thing to do.  I'll leave it to the respective
maintainers to review their bits of code.

> diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
> index 80b604c..9f41d39 100644
> --- a/libavformat/mpegts.c
> +++ b/libavformat/mpegts.c
> @@ -934,7 +934,8 @@ static void mpegts_push_data(MpegTSFilter *filter,
>  static AVStream* new_pes_av_stream(PESContext *pes, uint32_t code)
>  {
>      AVStream *st;
> -    int codec_type, codec_id;
> +    enum CodecID codec_id;
> +    enum CodecType codec_type;
>
>      switch(pes->stream_type){
>      case STREAM_TYPE_AUDIO_MPEG1:

OK

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list