[FFmpeg-devel] [PATCH] RDT/Realmedia patches #2

[Luca Barbato]

Ronald S. Bultje wrote:
> Hi Luca,
> 
> On Wed, Oct 1, 2008 at 2:00 AM, Luca Barbato <lu_zero at gentoo.org> wrote:
>> Ronald S. Bultje wrote:
>>> On Tue, Sep 30, 2008 at 9:42 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>>>> On Tue, Sep 30, 2008 at 9:36 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>>>>> As always, my full applied patch-tree against trunk SVN is at [1], I
>>>>> hope you can see it shrinking over time.
>>>> [..]
>>>>> [1] http://www.gnome.org/~rbultje/ffmpeg-realmedia-rtsp/
>>>> And here's another one, which makes RTPDemuxContext opaque for
>>>> DynamicProtocolHandler functions. The advantage of this is that we
>>>> don't rely on DynamicProtocol* being limited to using RTPDemuxContext,
>>>> which would in a theoretical next patch (coming in 2 minutes)
>>> And that patch is here.
>> Could you try to minimize it?
> 
> You mean split?

A split is fine.

> So, rtsp.c currently hardcodes RTPDemuxContext. My patches allow RDT
> to be used in addition to RTP, and LucaA asked to not use the RTP API
> in these cases. Therefore, we split it in such a way that RDT uses
> rdt_*() and RDT* API, while RTP uses rtp_*() and RTP* API. rtsp.c then
> decides which one to call based on the chosen transport protocol
> during the SETUP.
> 
> This change means RTSP may serve either RTP or RDT, and thus we
> shouldn't hardcode the type of structure of the "transport context",
> or rtp_ctx. This patch makes that type opaque in rtsp.c. This is not a
> problem, since rtsp.c never accesses any members of that struct,
> except for one case (see below).

Hmm then probably you should first make opaque also the name of the field.

> I think I moved it so that the new rtp_parse_set_dynamic_protocol()
> function, declared in rtp.h, can be declared with
> RTPDynamicProtocolHandler. Alternatively, I can make that function use
> void * instead, that works too. I can also split so that I first apply
> this move-of-struct-typedef and then the other parts (if you want me
> to split patches, please let me know, not all of this is split to the
> fullest extent possible). The function is needed to ensure that rtsp.c
> doesn't access RTPDemuxContext, because that may not actually be a
> RTPDemuxContext, but a RDTDemuxContext.

Ok.

lu

-- 

Luca Barbato
Gentoo Council Member
Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero