[FFmpeg-devel] [PATCH] vp3.c: Don't compile a debug loop

[David Conrad]

On Oct 1, 2008, at 6:07 AM, Michael Niedermayer wrote:

> On Tue, Sep 30, 2008 at 03:32:11PM -0400, David Conrad wrote:
>> On Sep 30, 2008, at 12:57 PM, Michael Niedermayer wrote:
>>
>>> On Mon, Sep 29, 2008 at 09:51:35PM -0700, Mike Melanson wrote:
>>>> David Conrad wrote:
>>>>> Patch attached (with small cosmetic patchs), as well as another to
>>>>> remove unused code that's been moved elsewhere.
>>>>
>>>> Wow, I wrote a lot of debug infrastructure. Patch #1 looks fine.
>>>> Deferring to Michael on 2 and 3 to make sure they meet his  
>>>> standards.
>>>
>>> 2 looked a little like it combined unrelated changes
>>> 3, if its just reindent should be ok
>>
>> Here's 2 split up even further.
>
> hmm this is ok but the reason why i asked for it to be split was:
>
> @@ -1260,8 +1260,6 @@ static void  
> reverse_dc_prediction(Vp3DecodeContext *s,
>                         else if (FFABS(predicted_dc - vul) > 128)
>                             predicted_dc = vul;
>                     }
> -
> -                    DC_COEFF(i));
>                 }
>
>                 /* at long last, apply the predictor */
> @@ -1298,7 +1296,6 @@ static void vertical_filter(unsigned char  
> *first_pixel, int stride,
> static void render_slice(Vp3DecodeContext *s, int slice)
> {
>     int x;
> -    int m, n;
>     int16_t *dequantizer;
>     DECLARE_ALIGNED_16(DCTELEM, block[64]);
>     int motion_x = 0xdeadbeef, motion_y = 0xdeadbeef;
> -----------
> which was in patch #2 ...
> and that surely does not belong in the keyframe patch ...
> i didnt mean so much that the part you splited has to be split ...

Sorry about those stray lines, they were meant to be part of the 1st  
patch removing the debug stuff (DC_COEFF(i) was the last line of a  
printf statement and caused a syntax error by itself.) I caught them  
before sending out my email and I thought I fixed the patches, but I  
was wrong.

Anyways, applied in 3 parts.