[FFmpeg-devel] [PATCH] Improve documentation and error reporting for the -pass option
Sun Nov 30 18:05:53 CET 2008
Stefano Sabatini wrote:
> On date Sunday 2008-11-30 11:14:47 -0500, The Wanderer encoded:
>> Stefano Sabatini wrote:
>>> Check the patch attached, there is still a grouping issue but I
>>> think that we can go with that...
>> Yes, it's better (and better than I would likely have been able to
>> do). I see one possible way to maybe improve it further, but there
>> are potential problems with that too, so I'd call this good enough
>> as far as that goes.
>> I would, however, probably say "that log file is used" rather than
>> "that log file is read". That's not worth reposting the patch over,
> Yes, also I've made explicit in the first sentence that the option is
> used for *video* encoding. I'll apply tomorrow if no one has other
> suggestions/objections or before if Diego gives its explicit approval
> (sorry to waste your bandwidth Diego ;-)).
Looks good to me. I'd say commit.
Warning: Simply because I argue an issue does not mean I agree with any
side of it.
Secrecy is the beginning of tyranny.
More information about the ffmpeg-devel