[FFmpeg-devel] [PATCH] Improve documentation and error reporting for the -pass option

The Wanderer inverseparadox
Sun Nov 30 14:32:02 CET 2008


Stefano Sabatini wrote:

> On date Sunday 2008-11-30 13:11:06 +0100, Diego Biurrun encoded:
> 
>> On Sun, Nov 30, 2008 at 12:43:56PM +0100, Stefano Sabatini wrote:
>> 
>>> Yes, it's better, thanks.
>>> 
>>> --- doc/ffmpeg-doc.texi	(revision 15955)
>>> +++ doc/ffmpeg-doc.texi	(working copy)
>>>  @item -passlogfile @var{file}
>>> -Set two pass logfile name to @var{file}.
>>> +Set two pass logfile name to @var{file}. Default name is
>>> + at file{ffmpeg2pass-N.log}, where N is a number specific of the output
>>> +stream.
>> 
>> specific to
>> 
>> Commit.
> 
> Just another nitpick, "log file" or "logfile"?

"log file" is more correct, but then that leads to grouping issues
(which are already there because "two pass" is being used as an
adjective but isn't joined with e.g. a hyphen) which can be very hard to
solve.

I take it this is in reaction to the discussion over on -user with
"Viaduct Productions"?

As a fix for that issue I'm not terribly happy with this, particularly
since he(?) hasn't said "yes, this would have avoided confusion as far
as I was concerned" or similar, but I don't have anything solid to base
objections on.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.




More information about the ffmpeg-devel mailing list