[FFmpeg-devel] [PATCH] SDP muxer

Michael Niedermayer michaelni
Thu Nov 27 00:58:54 CET 2008

On Fri, Nov 21, 2008 at 07:43:47PM +0100, Aurelien Jacobs wrote:
> Luca Abeni wrote:
> > Hi,
> > 
> > Stefano Sabatini wrote:
> > [...]
> > >>>> while I think the expected behaviour for the muxer would be to take a
> > >>>> list of *AVStreams* and create from these the header.
> > >>> Maybe. But then, is it still possible to have different destination
> > >>> multicast groups for different streams? I mean: does an AVStream allow
> > >>> to store the destination MC group (and port) somewhere?
> > > 
> > > I'm the mapping code of ffmpeg.c I'm storing the AVFormatOutput
> > > filename in the AVStream filename, which is then used to compute the
> > > destination address. It works but looks very fragile and I'm not very
> > > happy about it.
> > 
> > I did not know about AVStream->filename. What's its expected behaviour?
> > The comments says "source filename of the stream", which does not make
> > too much sense in this case... Is it ok to use AVStream->filename in this
> > way? Where is it used in libavformat, and who sets it?
> IIRC it is currently used only for attachment streams (eg. a ttf font
> embedded in a mkv file). Subtitles often refer to fonts by their filename,
> which have to be exported in case of embedded font.
> So, IOW, AVStream->filename should be the name of the original raw stream
> file which was used to when muxing to the container, and this should be the
> default/preferred name if the raw stream is dumped again into a file.
> I'm not sure your proposition would fit with this definition...

I really do not like how mkv and subtitles interact, this is really sick
design, fonts have names or whatever the correct term is. Filenames really
seem the wrong way to identify them.

btw, i think this thread shows that the documentation of AVStream.filename
is insufficient ...
I think this should be improved

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081127/6cfc9b2b/attachment.pgp>

More information about the ffmpeg-devel mailing list