[FFmpeg-devel] [PATCH] QCELP decoder

Reynaldo H. Verdejo Pinochet reynaldo
Wed Nov 26 04:30:58 CET 2008

Hi Michael, thanks for your quick answer.

Michael Niedermayer wrote:
> One point in favor of the parser though is copying the packets into another
> container, in that case the trash should be discarded somewhere along the
> way. This though could be done with a bitstream filter or maybe the trash
> could even be discarded by the mov demuxer (if its only a problem of mov
> files)

I still don't think this is the QCELP decoder's job, to account for a
given format or transport oddity that is. But now that you made the
parser's 'raison d'etre' clearer I'd favor this change to take place
on the mov demuxer (and in the rtp code when needed) as long as it can
be implemented easily and in a clean way, if it doesn't the parser
becomes appealing again. I did suggested the chance of implementing
this change in the demuxer before, I just don't think it belongs to
the decoder's code.


More information about the ffmpeg-devel mailing list