[FFmpeg-devel] [PATCH] move QUANT_SHIFT #define to a sensible place

Michael Niedermayer michaelni
Wed Nov 26 03:07:31 CET 2008


On Wed, Nov 26, 2008 at 01:41:25AM +0100, Diego Biurrun wrote:
> On Mon, Nov 24, 2008 at 04:26:53PM +0100, Michael Niedermayer wrote:
> > On Mon, Nov 24, 2008 at 02:08:14PM +0100, Diego Biurrun wrote:
> > > QUANT_SHIFT is only used in one function in h264.c, but it is hidden
> > > somewhere between long tables in h264data.h.  This patch moves it to
> > > h264.c.
> > 
> > both the table as well as the single function using it belong to our
> > unfinished h264 encoder
> > 
> > also the values of the table are scaled by QUANT_SHIFT, thus the define
> > does in some sense belong to the table
> 
> OK, alternative patch attached.  

ok


> Anything else that should be moved to
> the encoder?

iam not aware of anything else, that doesnt mean though there is nothing
else ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081126/ab0fefb1/attachment.pgp>



More information about the ffmpeg-devel mailing list