[FFmpeg-devel] [RFC] ratecontrol buffer size magic

Michael Niedermayer michaelni
Wed Nov 26 01:33:33 CET 2008


On Wed, Dec 05, 2007 at 04:46:14PM +0100, Stefano Sabatini wrote:
> On date Monday 2007-11-19 11:09:34 +0100, Stefano Sabatini encoded:
> > On date Tuesday 2007-10-16 22:20:17 +0200, Michael Niedermayer encoded:
> > > Hi
> > > 
> > > On Tue, Oct 16, 2007 at 12:17:26PM +0200, Baptiste Coudurier wrote:
> > > > Hi Michael,
> > > > 
> > > > Michael Niedermayer wrote:
> > > > > Hi
> > > > > 
> > > > > On Tue, Sep 25, 2007 at 12:00:02PM +0200, Baptiste Coudurier wrote:
> > [...]
> > > > >> Another try:
> > > > >>
> > > > >> /**
> > > > >>   * Ratecontrol factor applied to vbv buffer free space when limiting QP
> > > > >> (bits2qp).
> > > > >>   * With a maximum rate: free space / factor;
> > > > >>   * With a minimum rate: free space * factor;
> > > > >>   * - encoding: Set by user.
> > > > >>   * - decoding: unused
> > > > >>   */
> > > > >>   float rc_vbv_to_qp_factor;
> > > > >>
> > > > >> {"rc_vbv_to_qp_factor", "ratecontrol vbv buffer free space to qp
> > > > >> factor", OFFSET(rc_vbv_buf_free_space_to_qp_factor), FF_OPT_TYPE_FLOAT,
> > > > >> 3.0, FLT_MIN, FLT_MAX, V|E},
> > > > >>
> > > > >> Im trying to keep name somewhat short.
> > > > > 
> > > > > please split this variable in 2
> > > > > 2 good names would be:
> > > > > 
> > > > > rc_max_available_vbv_use (default 1.0/3)
> > > > > that is attempt use at maximum 1/3 of what we can use without a underflow
> > > > > 
> > > > > rc_min_vbv_overflow_use (default 3)
> > > > > that attempt to use at least 3 times the amount we must use to prevent
> > > > > a vbv overflow
> > > > > 
> > > > 
> > > > Patch attached.
> > > 
> > > ok
> > 
> > I'm interested in this patch too. Since Michael OKed it could someone
> > apply it?
> > 
> > I diffed the previous patch against the latest SVN, in order to get a
> > clean patch.
> 
> Ping + patch diffed against latest SVN. I also added a bump to
> libavcodec minor.
> 
> Regards.
> -- 
> Stefano Sabatini
> Linux user number 337176 (see http://counter.li.org)

Is there any reason why this one wasnt applied?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081126/448c9340/attachment.pgp>



More information about the ffmpeg-devel mailing list