[FFmpeg-devel] [PATCH] make non-void function in snow.h return a value

Uoti Urpala uoti.urpala
Mon Nov 24 17:38:07 CET 2008


On Mon, 2008-11-24 at 17:07 +0100, Diego Biurrun wrote:
> 'make checkheaders' complains about two functions returning non-void
> when encoders are disabled.  Here is a patch to address this.

> -static int w53_32_c(void *v, uint8_t * pix1, uint8_t * pix2, int line_size, int h) {assert (0);}

> +static int w53_32_c(void *v, uint8_t * pix1, uint8_t * pix2, int line_size, int h) {assert (0); return 0;}

Is the file compiled with NDEBUG defined? Or did you test with a bad GCC
version? Normally GCC can tell that a function will not return after an
"assert(0);".

If it's normally compiled with NDEBUG defined then using "abort();"
instead of "assert(0);" might be preferable.





More information about the ffmpeg-devel mailing list