[FFmpeg-devel] [PATCH] convert fdct_mmx.c to plain asm

[Michael Niedermayer]

On Sun, Nov 23, 2008 at 11:42:11PM -0800, Baptiste Coudurier wrote:
> Michael Niedermayer wrote:
> > On Thu, Nov 13, 2008 at 10:39:37AM -0800, Baptiste Coudurier wrote:
> >> Hi Michael,
> >>
> >> Michael Niedermayer wrote:
> >>> On Wed, Nov 12, 2008 at 06:54:23PM -0800, Baptiste Coudurier wrote:
> >>>> Hi
> >>>>
> >>>> $subject, I hope I did not mess up.
> >>> ok, if its output didnt change
> >> Yeah, it is obvious. No other comment ?
> > 
> > I have many but they dont belong in this patch :)
> > like not using "r" but MANGLE() to prevent slow GOT indirection,
> > and to turn the asm parts into just parts of a single asm() instead of
> > 3 asm()
> > 
> > 
> >> Like a better way to use the macro, I find it a bit ugly.
> > 
> > #define SHIFT_FRW_COL_STR "3"
> > should work to avoid S()
> 
> Btw, I noticed some funcs are using %n, and "i" constraint, wouldn't it
> be better ?

if you test that 2.95 & 3.3/3.4 dont miscompile it, old gcc where sensitive
to large numbers of constraints.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081124/d644db3a/attachment.pgp>