[FFmpeg-devel] [PATCH] RV40 Loop Filter, hopefully final version

Kostya kostya.shishkov
Sun Nov 23 20:47:05 CET 2008


On Sun, Nov 23, 2008 at 07:23:32PM +0100, Michael Niedermayer wrote:
> On Sun, Nov 23, 2008 at 04:40:28PM +0200, Kostya wrote:
> > On Sun, Nov 23, 2008 at 02:49:18PM +0100, Michael Niedermayer wrote:
> > > On Sun, Nov 23, 2008 at 09:15:58AM +0200, Kostya wrote:
> > > > On Sun, Nov 23, 2008 at 09:15:03AM +0200, Kostya wrote:
> [...]
> > [...]
> > > > +                            if(!i){
> > > > +                                clip_left = uvcbp[POS_LEFT][k] & (MASK_CUR << (2*j+1)) ? clip[POS_LEFT] : 0;
> > > > +                            }else{
> > > > +                                clip_left = uvcbp[POS_CUR][k]  & (MASK_CUR << (ij-1))  ? clip[POS_CUR]  : 0;
> > > > +                            }
> > > 
> > > if(i)
> > > else
> > > is clearer than if(!i) IMHO
> > 
> > IMNSHO too
> 
> ?
> you disagree?
> or you agree but forgot to change it?
 
the second one
some cases held debug statements or were prepared to have one
 
[loop filter code]

I took the liberty to commit it (with your corrections) since everything
in that function was reviewed and changed. In case something is still
wrong with it - I'm more or less around.

That leaves us with dreadful loop filter invoking code and motion functions
(I've sent one version to ML but please disregard it since it was wrong
temporary version, the one I've committed to soc svn works correctly though).

> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB




More information about the ffmpeg-devel mailing list