[FFmpeg-devel] [PATCH] QCELP decoder

[Kenan Gillet]

On Nov 21, 2008, at 3:08 AM, Michael Niedermayer wrote:

> On Thu, Nov 20, 2008 at 06:04:20PM -0800, Kenan Gillet wrote:
>> Hi,
>> On Nov 20, 2008, at 4:36 PM, Reynaldo H. Verdejo Pinochet wrote:
>>
>>> Hello
>>>
>>> Reynaldo H. Verdejo Pinochet wrote:
> [...]
>>>
>>>
>>>> and I changed on the 10/27/2008 to
>>>>    RATE_UNKNOWN = -2,
>>>>    I_F_Q,             /*!< insufficient frame quality */
>>>>    SILENCE,
>>>>    RATE_OCTAVE,
>>>>    RATE_QUARTER,
>>>>    RATE_HALF,
>>>>    RATE_FULL
>>>> when you asked me to change the
>>>> switch (framerate)
>>>>  case RATE_FULL:
>>>>  case RATE_QUARTER:
>>>>  case RATE_OCTAVE:
>>>> }
>>>> to (framerate >= RATE_QUARTER)
>>>>
>>>> After sending the patch round 10, I also added a check to make sure
>>>> the buffer
>>>> contains enough data for the the frame to be decoded without  
>>>> reading
>>>> garbage.
>>>
>>> I dont think that change is needed neither as that should be
>>> guaranteed by your demuxer - parser(?) chain.
>>
>> In order to read the two samples h263.mov and blue_earth.mov,
>> we need to look at the rate byte in the frame (as the spec describes)
>> and not just rely on the buffer_size
>> since for those files, the buffer_size is always 35 but they contains
>> RATE_FULL, RATE_HALF, RATE_QUARTER and RATE_OCTAVE.
>
> and what is the rest of the 35 bytes?

the rest is mostly 0
>
> trash? the next frame?

just trash


>
> also do these files decode correctly?

yes, it does decode correctly then.