[FFmpeg-devel] [PATCH] QCELP decoder

Michael Niedermayer michaelni
Fri Nov 21 02:13:56 CET 2008


On Thu, Nov 20, 2008 at 04:50:46PM -0800, Kenan Gillet wrote:
> 
> On Nov 20, 2008, at 4:03 PM, Reynaldo H. Verdejo Pinochet wrote:
[...]
> Concerning the renaming issue, the unpacking used to be done
> 1bit at a time in the SoC code, and qcelp_bits_per_rate was
> used more like the size of the unpacking tables.
> But during the review, Michael remarked that the unpacking
> could be done by block of bits instead, which would lead to smaller
> unpacking table and even maybe some faster code.

besides smaller and faster, i really think the new tables are more
readable due to containing actual names of fields in the source instead
of just litteral numbers

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081121/2b533d86/attachment.pgp>



More information about the ffmpeg-devel mailing list