[FFmpeg-devel] [PATCH] Improve ffpreset error messages

[Stefano Sabatini]

On date Thursday 2008-11-20 12:12:19 +0100, Michael Niedermayer encoded:
> On Thu, Nov 20, 2008 at 12:57:00AM +0100, Stefano Sabatini wrote:
> > Hi all,
> > 
> > sorry for the pickyness, maybe they should go in two separate commits.
> > 
> > The first change provides the exact line showing a syntax problem,
> > like here:
> > ./ffpresets/libx264-bugged.ffpreset: Invalid syntax: foobar baz # foo
> > 
> > the second one uses the exact line found in the file, for example the
> > user could specify "key=    value" while the message will tell: 
> > "Invalid option or argument: key=value"
> 
> could be 'Invalid option or argument: "%s", parsed as %s = %s'

Seconded.

Example output:

stefano at geppetto ~/s/ffmpeg> ffmpeg -vpre ./ffpresets/libx264-bugged.ffpreset
[...]
./ffpresets/libx264-bugged.ffpreset: Invalid syntax: 'foobar baz # foo'

stefano at geppetto ~/s/ffmpeg> ffmpeg -vpre ./ffpresets/libx264-bugged2.ffpreset
[...]
Unable to parse option value "  =       -1": undefined constant or missing (
Unable to parse option value "  =       -1": undefined constant or missing (
Unable to parse option value "  =       -1": undefined constant or missing (
./ffpresets/libx264-bugged2.ffpreset: Invalid option or argument: 'coder=  =       -1', parsed as 'coder' = '  =       -1'

Regards.
-- 
FFmpeg = Forgiving and Friendly Magical Prodigious Eager Goblin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-pre-ctx-01.patch
Type: text/x-diff
Size: 897 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081120/42971e8a/attachment.patch>