[FFmpeg-devel] AAC-Main (round 2)

[Michael Niedermayer]

On Thu, Nov 20, 2008 at 10:25:51AM -0000, M?ns Rullg?rd wrote:
> 
> Michael Niedermayer wrote:
> > On Wed, Nov 19, 2008 at 01:42:55PM -0500, Alex Converse wrote:
> > [...]
> >> diff --git a/libavcodec/aac.c b/libavcodec/aac.c
> >> index 1ad0a58..9fb242b 100644
> >> --- a/libavcodec/aac.c
> >> +++ b/libavcodec/aac.c
> >> @@ -91,6 +91,11 @@
> >>  #include <math.h>
> >>  #include <string.h>
> >>
> >> +#ifdef ARCH_X86
> >> +#define USE_754_PUNS
> >> +union float754 { float f; uint32_t i; };
> >> +#endif
> >
> > The correctness of the USE_754_PUNS code could be tested by configure
> 
> Not easily.  The best we could do is set it based on architecture.

hmm, is there a problem i miss with just compiling a
float a[]= {1.23456789, PI, E, -23.456789}
and checking if the IEEE expected byte sequence (for matching integer
endianness) is in the object file?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081120/51cebaab/attachment.pgp>