[FFmpeg-devel] [PATCH] H.264 data tables cleanup

Michael Niedermayer michaelni
Thu Nov 20 10:14:37 CET 2008

On Thu, Nov 20, 2008 at 12:29:50AM -0800, Jason Garrett-Glaser wrote:
> On Thu, Nov 20, 2008 at 12:08 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Nov 20, 2008 at 12:49:03AM +0100, Diego Biurrun wrote:
> >> So I've (re)started working on splitting off svq3.c from h264.c.
> >>
> >> Here are some simple first steps:
> >>
> >
> >> - Remove unused tables from h264data.h.
> >
> > these tables are unused because we dont have an encoder ...
> > putting them under appropriate ifdef or in a seperate encoder
> > specific (not compiled) header seems better than removing them
> > even if there are no plans for an encoder ...
> What's the point though?  If someone wants them at some time in the
> future, can't they just restore them from svn history?  Why keep
> around code that has no plans to be used, even if ifdef'd out?

because when someone might want to write a encoder or bitstream generator
he will likely not find such tables and functions when they have been removed
even if they are somewhere in the history.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081120/e0776415/attachment.pgp>

More information about the ffmpeg-devel mailing list