[FFmpeg-devel] [PATCH] OGG seeking and timestamp

Yvan Labadie ylabadie
Wed Nov 19 15:12:30 CET 2008

Stefano Sabatini a ?crit :
> On date Wednesday 2008-11-19 10:43:23 +0100, Yvan Labadie encoded:
> [...]
>> diff -cr ffmpeg-export-2008-10-10/libavformat/oggdec.c ffmpeg-export-2008-10-10_modif/libavformat/oggdec.c
> Ouch! Use diff -u patches, as used by svn diff, also you should use
> just that to ease your work.
Sorry, noob inside...
NB : I just found "MPlayer patch guidelines" I think I have some reading 
to do... (better late than never)

> [...]
> Weird indent, timeStamped doesn't look like a good name, also
> use_time_stamp style is preferred.
I replaced my "timeStamped" variable by "have_time_stamp" but I'm not 
quite sure this is what you meant....
and I corrected the weird indentation problems that were in my previous 
patch try
and I made the patch using lastest daily snapshot (I'm firewalled so I 
cannot use svn)

I hope this time I didn't break a rule!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_ogg.diff
Type: text/x-patch
Size: 4863 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081119/cbcab2af/attachment.bin>

More information about the ffmpeg-devel mailing list