[FFmpeg-devel] Request for review

[Michael Niedermayer]

On Tue, Nov 18, 2008 at 01:57:44PM -0800, Roman V. Shaposhnik wrote:
> Hi Michael!
> 
> Thanks for reviewing it so quickly!
> 
> On Tue, 2008-11-18 at 14:32 +0100, Michael Niedermayer wrote:
[...]
> > > -    if (d->work_chunks[dv_work_pool_size(d)-1].buf_offset)
> > > -        return 0;
> > > -
> > > +    if (!d->work_chunks[dv_work_pool_size(d)-1].buf_offset) {
> > >      p = i = 0;
> > >      for (c=0; c<d->n_difchan; c++) {
> > >          for (s=0; s<d->difseg_size; s++) {
> > > @@ -227,42 +225,45 @@ static int dv_init_dynamic_tables(const DVprofile *d)
> > >              }
> > >          }
> > >      }
> > > -    return 0;
> > >  }
> > >  
> > 
> > ok, though this seems unrelated and could be a seperate commit
> 
> Do you mean that something like I've attached should be a separate
> commit?

yes


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081119/9af4e160/attachment.pgp>