[FFmpeg-devel] [PATCH]don't abort on files with malformed chapters

Michael Niedermayer michaelni
Tue Nov 18 22:03:54 CET 2008

On Tue, Nov 18, 2008 at 08:54:18PM +0100, Anton Khirnov wrote:
> I suppose we still want to play files with incorrectly defined chapters ;)


> and the function could be renamed to av_sanitize_chapters.

no, i certainly will not agree to rename a function computing the end
to av_sanitize_chapters(). These are 2 seperate things

> btw what would be the correct thing to do with different timebases? do
> we allow that or not?

the fact that there is an assert() makes it clear we do not allow it
currently. This could be changed in case there is some sense in it and
after some disscussion about it has found that sense.

Either way, it is not allowed for a demxuer to feed the core with
invalid chapters.
Changeing what is invalid is more involved than hacking one function
that failed with values that are not allowed.

As first step it would have to be documented, second code using it
would have to be checked and changed as needed. The change would have
to make some sense and be justified ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081118/c1b1675b/attachment.pgp>

More information about the ffmpeg-devel mailing list