[FFmpeg-devel] [PATCH] RDT/Realmedia patches #2

Michael Niedermayer michaelni
Mon Nov 17 08:23:23 CET 2008


On Sun, Nov 16, 2008 at 06:56:34PM -0500, Ronald S. Bultje wrote:
> Hi again,
> 
> On Sun, Nov 16, 2008 at 6:51 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > On Sun, Nov 16, 2008 at 4:06 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> On Sun, Nov 16, 2008 at 04:06:06PM -0500, Ronald S. Bultje wrote:
> >>> void function ( [..], int *pis_key, [..])
> >>> {
> >>> int is_key;
> >>> [..]
> >>> is_key = !get_bits1(&gb);
> >>> [..]
> >>> if (pis_key) *pis_key = is_key;
> > [..]
> >> i prefer the temporary vars
> >
> > OK, $attached.
> 
> Grr, minus typos...

fine as well, anyway
i think you should test code before submitting, i mean the previous
patch clearly wouldnt have compiled without that ;

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081117/f3281c6f/attachment.pgp>



More information about the ffmpeg-devel mailing list