[FFmpeg-devel] [PATCH] RDT/Realmedia patches #2

Ronald S. Bultje rsbultje
Sun Nov 16 17:18:17 CET 2008


On Sun, Nov 16, 2008 at 10:32 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sat, Nov 15, 2008 at 03:51:17PM -0500, Ronald S. Bultje wrote:
>> +#define UPDATE_LEN(x) \
>> +    buf += x; \
>> +    len -= x; \
>> +    consumed += x;
> this is very ugly
> RTFS bitstream.c/h bytestream.h and the code using them

Attached patch makes the code use bitstream.h. It changes the return
statement, in a previous email you asked what that's for, it's
basically to be able to tell the length of the header. Here, it is
always 10 so it doesn't really make much of a difference, although it
works. In the next patch, I'd improve the header parsing
implementation to more closely match the spec, which makes the header
size variable, and then it's useful to have, so I already changed it
here... I can do that in 2 patches also.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rdt_parse_header-change-get_bits.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081116/ff21b9c2/attachment.asc>

More information about the ffmpeg-devel mailing list