[FFmpeg-devel] [PATCH][COSMETICS] to merged QCELP decoder code

Diego Biurrun diego
Sat Nov 15 21:26:54 CET 2008


On Sat, Nov 15, 2008 at 04:48:21PM -0300, Reynaldo H. Verdejo Pinochet wrote:
>
> I will apply these cosmetic fixes to the merged QCELP decoder
> code tomorrow if none disagrees. I'd like to keep my style
> consistent through the different incarnations of this code
> (HEAD and SoC repos).
>
> --- qcelpdec.c	(revision 15802)
> +++ qcelpdec.c	(working copy)
> @@ -38,15 +38,13 @@
>  
> -    for (i = 0; i < length; i++)
> +    for(i=0; i<length; i++)

I think it's more readable with spaces around the operators.

> @@ -67,25 +65,28 @@
>  
> -    for (i = 0; i < 4; i++)
> -        if (gain[i]) {
> +    for(i=0; i<4; i++)
> +    {
> +        if(gain[i])
> +        {

Judging from what I've seen around here I think the preferred style
keeps the opening brace on the same line as the if/for.

Diego




More information about the ffmpeg-devel mailing list