[FFmpeg-devel] [PATCH] QCELP decoder

[Kenan Gillet]

Hi Reynaldo,
On Nov 11, 2008, at 8:59 AM, Reynaldo H. Verdejo Pinochet wrote:

> Hello
>
> Michael Niedermayer wrote:
>> On Tue, Nov 11, 2008 at 04:17:55PM +0100, Diego Biurrun wrote:
>>>
>>> I'm not sure I understand what you want, but the priority should be
>>> merging code to FFmpeg.  The SoC repo is just a sandbox.  I don't  
>>> see
>>> what we would gain from improving it.
>>
>> I think i do understand reynaldos intent, i think his idea is to
>> check that no bugs/issues have been introduced between soc and the
>> patches kenan is posting now. And i agree that it does make sense to
>> check these changes, i just dont see an easy way to do it now without
>> delaying the merging effort.
>
> Yes, that's my intention, thanks for making it clearer.
>
> I'm thinking I will make the exercise to merge Kenan's changes into
> the SoC repo by myself, while trying to finish the still missing
> parts.
>
> It would be nice to have the patches made again and against the SoC
> repo but I don't plan to abuse Kenan's time in that way. Now If he
> wants to help doing this merging and continue working in the SoC repo
> till you guys are happy enough with the result to allow it to be
> merged back to HEAD, then by all means give him write rights to the
> SoC repo, that will at least spare him the burden of having to  
> maintain
> his own. I will just ask him to please continue asking for review on
> any new, not already reviewed change.
>
> I'm starting with the merge today.

First, I want to say that I am willing to help :)

My local subversion start at the inclusion of the SoC qcelp code at  
r2373.
Following this particular revision are only 2 minor revisions of  
cosmetics
and grammar.

So we are more talking the SoC svn tree and its continuation in my  
subversion.
Maybe a less painful path might be to import my local commits into the
SoC?

Furthermore, my first intent was to implement I_F_Q and RATE_OCTAVE
and I tried to keep the code close to the original,
so the first patch [1] I submitted should be closer to the code in SOC.

I's only after the first review that it started to divert...

let ken know your thoughts

Kenan

[1] http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2008-September/054094.html