[FFmpeg-devel] [patch] 6 channel rawaudioinputresultsininvalid PCM packet error

Michael Niedermayer michaelni
Tue Nov 11 21:04:26 CET 2008


On Mon, Nov 10, 2008 at 12:42:23PM -0800, Phil Rutschman wrote:
> > setting it to 8 if av_get_bits_per_sample() returns 0 does seem rather
> > wrong.
> 
> Fixed. The value is now simply assigned. Let me know if you prefer an
> error message and return to the assert, but it is IMHO a bug for
> av_get_bits_per_sample to return zero when passed the ID of a raw PCM
> codec, so an assert seemed appropriate.
>  
> > 
> > tabs are forbiden in ffmpeg svn
> 
> Fixed.
> 
> I also added a comment explaining why the packet size needs manipulating
> in the first place. 

ok if it passes the regression tests

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081111/ddf1c607/attachment.pgp>



More information about the ffmpeg-devel mailing list