[FFmpeg-devel] [PATCH] QCELP decoder

Kenan Gillet kenan.gillet
Mon Nov 10 02:34:35 CET 2008


On Nov 9, 2008, at 12:29 PM, Michael Niedermayer wrote:
>>>> +    case SILENCE:
>>>> +        av_log_missing_feature(avctx, "Blank frame", 1);
>>>> +    default:
>>>> +        q->framerate = I_F_Q;
>>> is it intended that SILENCE sets IFQ ?
>> Not in my code, this is the kind of changes I'd like
>> to see out of the 'merging' attempt and back as
>> patches against the SoC code, I don't have your gifted
>> sight, I get lost. Merging the soc code with cosmetic
>> fixes into HEAD and latter working on these functional
>> changes would be OK too. Is that something you'd be
>> willing to accept? I'm OK with either way, I just
>> don't want to handle both tasks in the same patchset.
> code wont be commited to HEAD until its ok both functionally and  
> cosmetically
> about following kenans changes, well, we could just give him write  
> access
> to soc-svn if you agree, or if he is using git or something like  
> that he
> maybe could provide some history between soc and the current code.

I am using subversion so I could provide the history of my commits...
The code changed quite a bit and there are roughly 300 commits.
Going over every commit and merging it with the SOC repository
could be a a time-consuming process, and I would rather spend
the time getting it committed to head.

Let me know what you prefer.


More information about the ffmpeg-devel mailing list