[FFmpeg-devel] [PATCH] QCELP decoder

Reynaldo H. Verdejo Pinochet reynaldo
Sun Nov 9 16:59:55 CET 2008

Hello Kenan

Kenan Gillet wrote:
> On Oct 15, 2008, at 4:40 AM, Aurelien Jacobs wrote:

>>> - cosmetics

I haven't reached the end of this thread yet
so forgive me if I'm saying this again: cosmetic
and gramar patches alone please, not mixed with
other changes.

Also, modifying functional code in the SoC repo
and upstream merging a completely aproved decoder
are two different tasks and IMHO should be cleanily
handled as two different operations and patchsets.
Please submit aproved changes as patches against the
SoC repo instead, I will apply them. The other
direction should work too I guess, merging upstream
and latter working on functional changes. I just
don't want to handle both operations at once and
think the former way would be better liked by the
rest of the crew. I would like to know what others
have to say about this.

>>> - split lsp2lpc code into its own file qcelp_lsp.c

Why ?

>>> - small optimizations
>>> - bug fixes
>>> For info, postfilter and final gain control are still missing.

I'm on it.


More information about the ffmpeg-devel mailing list