[FFmpeg-devel] FASTDIV macro

[Måns Rullgård]

Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:

> On Sun, 2008-11-09 at 13:52 +0100, Michael Niedermayer wrote:
>> On Sat, Nov 08, 2008 at 09:49:24PM +0000, M?ns Rullg?rd wrote:
>> > There is also a question of where this macro belongs.  It uses a table
>> > defined in lavc, and its only use outside lavc is in ff_sqrt(), which
>> > is only used in lavc.  Would it make sense to move these to
>> > lavc/mathops.h, where other similar macros are defined?
>> > Alternatively, mathops.h could be moved to lavu.  I'd like it to be
>> > consistent.  The same goes for a number of other macros of this type.
>> 
>> i think that at least the table should be moved to lavu
>
> As I mentioned earlier in another thread, moving the table to lavu makes
> code accessing it from libavcodec more complex (you need to look up
> where in memory libavutil has been loaded). So there is at least some
> benefit in leaving it in libavcodec if that's where all the uses are.

Whether true or not, that argument applies to other tables as well.
Also, if the table is in lavc, it doesn't make sense to have the macro
in lavu.

-- 
M?ns Rullg?rd
mans at mansr.com