[FFmpeg-devel] [PATCH] Check for bugged make

[Stefano Sabatini]

On date Saturday 2008-11-08 16:10:17 +0100, Stefano Sabatini encoded:
[...]
> The question we have to address here is if we are *requiring* GNU make
> 3.81, or a compliant make utility.
> 
> As Ramiro pointed out, the user may choose to use one of the many make
> variants, make < 3.81, remake, gmake etc, this also means that when
> configuring configure doesn't know which is the make the user will
> invoke, so there's no point into checking the "make" command.
> 
> This would make sense if we're pretending the user to run explicitely
> the "make" command during the configuration, but I'm not sure if this
> is a common requirement. Furthermore, if we choose to *require* GNU
> make 3.81, then maybe we could simply explicitely tell this in the
> INSTALL file, and avoid the clutter necessary for detecting all the
> possible problems in other make versions.
> 
> Currently the only indication we give is:
> 
> |2) Then type 'make' to build FFmpeg. On BSD systems, type 'gmake'
> |instead of 'make'. You may need to install GNU Make 3.81 first.
> 
> Meaningwhile I tried the FFmpeg Makefile with remake 3.80 (which is a
> patched make 3.80, so maybe the same problem occurrs in make 3.80 as
> well), and discovered it doesn't work in a rather painful-to-debug
> way, I am adding the check in the attached patch.
> 
> BTW since check-make now contains multiple checks, to have it in a
> separate Makefile looks like the only way to be able to report in one
> place an error message, also I think it reduce the clutter in the main
> top level Makefile.
> 
> Anyway, maybe a simpler solution would be to require the use of GNU
> make 3.81, stress this in the docs, and avoid the clutter of automatic
> checks which furthermore won't necessarily work for the generic
> foomake.

Hi, r15796 definitively implements this solution, so now we're
*requiring* GNU make >= 3.81 and since now we're demanding the user to
use a valid version of make there is no need for random/hairy
automatic checks, and I'm dropping this patch.

Regards.
-- 
FFmpeg = Fantastic and Fostering Multimedia Picky Elitist Glue